Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI display names to tasks - Fixes #63 #65

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Add CI display names to tasks - Fixes #63 #65

merged 3 commits into from
Jan 10, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jan 8, 2020 •
edited
Loading

Pull Request (PR) description

Add CI display names to tasks.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

@johlju - would you mind reviewing for me?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jan 8, 2020
johlju
johlju approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

azure-pipelines.yml, line 184 at r1 (raw file):

publishPrerelease

Non-blocking. I changed this to publishRelease since it also releases full releases (and changed the display name accordingly)

@johlju
Copy link
Member

johlju commented Jan 8, 2020

I let you change the branch protection rules before you merge.

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Jan 8, 2020
johlju
johlju requested changes Jan 8, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @PlagueHO)

azure-pipelines.yml, line 185 at r2 (raw file):

'Publish Prerelease'

You should change this too :)

PlagueHO
PlagueHO commented Jan 9, 2020
View reviewed changes
Copy link
Member Author

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johlju - I made some other mistakes - can you review again for me? I'll also correct branch protection.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @johlju)

azure-pipelines.yml, line 185 at r2 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
'Publish Prerelease'

You should change this too :)

Done.

johlju
johlju approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 8d51ba6 into dsccommunity:master Jan 10, 2020
@PlagueHO PlagueHO deleted the Issue-63 branch January 10, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
ready for merge The pull request was approved by the community and is ready to be merged by a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set DisplayNames in CI Pipeline Tasks
2 participants
@PlagueHO @johlju